Open
Conversation
added 12 commits
October 28, 2024 13:56
I also removed the multheadedattention activation type (plus the associated apply_attention function) because they did not make sense in this class. I have now documented the MLP class, but need to add documentation to the autoencoder class.
I added comments + doc strings to the Autoencoder class.
gplasdi had an instance of np.Inf (which is depricated). I also fixed a typo in latent_spaces.py
I also reformatted enums.py
I still need to document the actual gplasdi class, but have done everything else in the file. I also made small tweaks to comments in other files.
I think I will move onto the LatentDynamics/Physics files before moving onto workflow.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added documentation to gplasdi.py and timing.py. These are the only two files that have seen major changes in this commit. In each case, the underlying code is the same, I have just added documentation so that the user can understand what the code does.